Optimize SIMM9 with TSO #4216
Open
Optimize SIMM9 with TSO #4216
+40
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was 32-bit Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
|
Looks like the CI failures are not spurious but actually a result of the change. |
| }; | ||
| } | ||
| if ((A.Base || A.Segment) && A.Offset) { | ||
| const bool SupportsSmallConst = A.AddrSize == OpSize::i32Bit && GPRSize == OpSize::i32Bit; |
There was a problem hiding this comment.
I think this needs to be const bool SupportsSmallConst = A.AddrSize == GPRSize; Otherwise we lose small const support for LRCPC2 on 64-bit processes with 64-bit addresses?
There was a problem hiding this comment.
I think the small const logic is wacked as it is on 64-bit. I'll investigate this a bit more.
Sonicadvance1
added a commit
to Sonicadvance1/FEX
that referenced
this pull request
Dec 20, 2024
The immediate offset masking was at the completely wrong offset when I wrote these handlers. No idea how I managed to mess those up so badly. Should fix at least some of the issues with FEX-Emu#4216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per @Sonicadvance1's nerdsnipe