ConstProp: fix 32-bit masking behaviour #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alyssarosenzweig
commented
Dec 13, 2024
alyssarosenzweig
commented
we don't need masking and the masking gets in the way of constprop. Signed-off-by: Alyssa Rosenzweig <[email protected]>
ycm complained. Signed-off-by: Alyssa Rosenzweig <[email protected]>
if we want to replace a node with one of its sources, we need to zero extend if the source is 64-bit and the destination is 32-bit. Signed-off-by: Alyssa Rosenzweig <[email protected]>
fails on main, fixed by this PR.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
alyssarosenzweig
force-pushed
the
fix/constprop-zext
branch
from
24f4c68 to
4934c1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.