Thunks/gen: Add support for compiling against clang 19

[WhatAmISupposedToPutHere]

No description provided.

[alyssarosenzweig]

nice cleanup :)

[neobrain]

Unit tests (BUILD_TESTS=ON) will still fail to compile with LLVM 19:

diff --git unittests/ThunkLibs/generator.cpp unittests/ThunkLibs/generator.cpp
index d3fc9c7c0..38eadbfd6 100644
--- unittests/ThunkLibs/generator.cpp
+++ unittests/ThunkLibs/generator.cpp
@@ -417,7 +417,7 @@ TEST_CASE_METHOD(Fixture, "VersionedLibrary") {

   CHECK_THAT(output, matches(callExpr(callee(functionDecl(hasName("dlopen"))), hasArgument(0, stringLiteral().bind("libname"))))
                        .check_binding(
-                         "libname", +[](const clang::StringLiteral* lit) { return lit->getString().endswith(".so.123"); }));
+                         "libname", +[](const clang::StringLiteral* lit) { return lit->getString().ends_with(".so.123"); }));
 }

 TEST_CASE_METHOD(Fixture, "FunctionPointerViaType") {

Other than that, tested and confirmed to produce working error messages equivalent to older LLVM versions. Well done!

[neobrain]

Apparently the CI runners still use LLVM 14 🙃
So we'll also need an #ifdef there. The new API name was introduced with LLVM 17.

EDIT: I answered too late, you already fixed it

[neobrain]

Perfect, thanks again!