Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEXCore: Removes ExitReason from InternalThreadState #4181

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

Sonicadvance1
Copy link
Member

FEXCore hasn't been returning anything other than EXIT_SHUTDOWN for a long time, so this ended up just moving data around for no reason.

This isn't going to be used for further GdbServer work anyway, so just completely remove it.

Copy link
Contributor

@lioncash lioncash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

FEXCore hasn't been returning anything other than EXIT_SHUTDOWN for a
long time, so this ended up just moving data around for no reason.

This isn't going to be used for further GdbServer work anyway, so just
completely remove it.
@Sonicadvance1 Sonicadvance1 merged commit f59fc0f into FEX-Emu:main Nov 29, 2024
12 checks passed
@Sonicadvance1 Sonicadvance1 deleted the remove_exitreason branch November 29, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants