Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64EC: Dynamically determine syscall numbers under wine. #4088

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

bylaws
Copy link
Collaborator

@bylaws bylaws commented Sep 27, 2024

Takes advantage of the consistent alphabetical syscall ordering that wine follows. This finally allows the CEF sandbox to work with arm64ec FEX under wine.

@bylaws bylaws marked this pull request as ready for review September 27, 2024 18:30
Copy link
Member

@Sonicadvance1 Sonicadvance1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully at some point we can get wine to export a syscall entry table so we don't have to do this. But until then this is fine.

@bylaws
Copy link
Collaborator Author

bylaws commented Sep 27, 2024

Hopefully at some point we can get wine to export a syscall entry table so we don't have to do this. But until then this is fine.

Yeah that won't happen :) There's no reason for wine to deviate from windows here when native apps can get syscall exports just fine through a bunch of different ways. The way done here is wine specific but if wine were to change their layout to match windows it would then be the case that hardcoding as is done for windows would work fine.

Takes advantage of the consistent alphabetical syscall ordering that
wine follows.
@Sonicadvance1 Sonicadvance1 merged commit 967c04e into FEX-Emu:main Oct 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants