Thunks: Move to the frontend #4075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
force-pushed
the
move_thunkhandler
branch
3 times, most recently
from
02c93ae to
9619587
Compare
This was a legacy feature that is no longer necessary every since we removed the frontend IRLoader.
…n to ContextImpl No functional change, just moving code here.
Prep commit to give Thunks the data it needs before moving.
With as little changes as possible, because this is fairly tricky.
Moves from FEXCore to FEX::HLE. Also moves the ThunkFunctions that get exposed to a namespace to make it more obvious that these are thunkhandlers rather than just static functions.
Backend doesn't need access to this at all
Because it was moved from the backend to the frontend, re-wire up the TLS handling which requires going through our syscall handler.
From prep commit 511103e. Now that the frontend is setup, we can remove the temporary TLS variables and use the ThreadObject directly.
Sonicadvance1
force-pushed
the
move_thunkhandler
branch
from
9619587 to
926fa3c
Compare
|
Rebased and merge conflict resolved. |
lioncash
reviewed
Sep 28, 2024
lioncash
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEX's thunks are fundamentally a Linux specific feature, but also with some interaction with the FEXCore in order to handle callback trampolines and passing the thunk information to the backend.
This takes the time to decouple these two halves and move it to the frontend FEXLoader. A little bit of restructuring necessary to be done in order to do this, but nothing too scary.
Walking the commits from earliest to latest will show some of the work necessary for decoupling.