Tools: Delete imgui FEXConfig #4066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neobrain
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Nice!
It's worth mentioning the commit structure here will make git log FEXConfig/Main.cpp show the old ImGui history instead of FEXQonfig's. That is probably the better choice since FEXQonfig's git history is fairly uninteresting.
However, if we wanted to preserve the FEXQonfig history, we could split the commit in two: One that removes FEXConfig, and one that renames FEXQonfig to FEXConfig.
Sonicadvance1
force-pushed
the
remove_imgui
branch
from
10ee8fd to
5af2e87
Compare
Sonicadvance1
force-pushed
the
remove_imgui
branch
from
5af2e87 to
987c18a
Compare
Sonicadvance1
force-pushed
the
remove_imgui
branch
from
987c18a to
35cb1f7
Compare
|
Split the commit to retain history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.