FEXServer/PipeScanner: Stop writing null to incoming pipes #4062
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing problems in a typical use case of piping stdout/stderr to another application. So if FEXInterpreter was started, with stdout piped to another application, and FEXServer wasn't running so a new instance needed to be started. FEXServer would write a null to every pipe then close it. This includes the stdout that is being piped to the new application! This writing was legacy behaviour before FEX was properly listening to POLLHUP and is no longer necessary. Just remove the writing completely to fix this issue. Easiest test case was just `./Bin/FEXInterpreter `which ls` / | xxd | head -n 3` Returned: ``` $ ./Bin/FEXInterpreter `which ls` / | xxd | head -n 3 00000000: 0000 0000 6269 6e0a 6269 6e2e 7573 722d ....bin.bin.usr- 00000010: 6973 2d6d 6572 6765 640a 626f 6f74 0a64 is-merged.boot.d 00000020: 6576 0a65 7463 0a68 6f6d 650a 6c69 620a ev.etc.home.lib. ``` That first null shouldn't be there.
lioncash
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing problems in a typical use case of piping stdout/stderr to another application. So if FEXInterpreter was started, with stdout piped to another application, and FEXServer wasn't running so a new instance needed to be started. FEXServer would write a null to every pipe then close it. This includes the stdout that is being piped to the new application!
This writing was legacy behaviour before FEX was properly listening to POLLHUP and is no longer necessary. Just remove the writing completely to fix this issue.
Easiest test case was just
./Bin/FEXInterpreter /usr/bin/ls / | xxd | head -n 3Returned:
That first null shouldn't be there.