Windows: Switch supported MinGW CRT to UCRT #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I applied it on top of 2408, needed to remove a const and had issues linking cause of control flow guards |
bylaws
force-pushed
the
ucrt
branch
2 times, most recently
from
d7f460c to
6dcdc0f
Compare
MSVCRT is deprecated and the reasons FEX used it no longer apply, so support UCRT and UCRT only.
Sonicadvance1
approved these changes
Sep 30, 2024
|
Is somewhere documented what toolchains are on the CI runners? As I understand you use your own runners instead of GitHub provided ones. |
https://wiki.fex-emu.com/index.php/Development:ARM64EC has a bit of documentation Currently using the toolchain from Bylaw's fork https://github.com/bylaws/llvm-mingw/releases/tag/20240929 Personally no idea what the difference is from upstream llvm-mingw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVCRT is deprecated and the reasons FEX used it no longer apply, so support UCRT and UCRT only.
Draft as not tested particularly well and this needs new CI binaries
cc: @AndreRH