CMake: Compile with system libraries for xxhash, Catch2, and fmt, if available #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neobrain
force-pushed
the
refactor_system_libs
branch
2 times, most recently
from
ccfa61c to
43c45cf
Compare
neobrain
force-pushed
the
refactor_system_libs
branch
from
43c45cf to
ab5d3ab
Compare
alyssarosenzweig
approved these changes
Sep 6, 2024
CMake has FetchContent for this. I played around with it today and it works in principle, but I'm not sure if the change would come with unexpected side effects (by sole virtue of being a change, as opposed to some specific weakness I've observed in FetchContent). |
Sonicadvance1
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of compiling these from bundled sources, check if the corresponding system libraries are installed first. This should help FEX packaging for Linux distributions (see #2996).