Windows: Fill in per-core MIDR information #4031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
approved these changes
Sep 3, 2024
neobrain
reviewed
Sep 4, 2024
|
|
||
| auto HostFeatures = FEX::FetchHostFeatures(Features, !IsWine, CTR, MIDR); | ||
| FillMIDRInformation(&HostFeatures, MIDR); | ||
|
|
||
| for (uint32_t Idx = 0; Key; Key = OpenProcessorKey(++Idx)) { |
There was a problem hiding this comment.
Is this intended to start at Idx==1 ? All documentation I could find (which wasn't a lot) suggests the first processor is at 0.
It's a bit of a weird way to express the iteration pattern either way; initializing to 1 and using post-increment would have been clearer.
There was a problem hiding this comment.
It starts at zero because the first iteration of the loop is for core zero which has its reg key already open from prior
There was a problem hiding this comment.
Ah... not the worst thing to do but rather subtle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.