Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPUID: add missing Apple core part numbers #4023

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

chadmed
Copy link
Contributor

@chadmed chadmed commented Sep 1, 2024

The Ultra-class SoCs are two Max-class SoCs connected via Apple's fabric, and thus use the same core revisions as the Max-class SoCs for both big and LITTLE cores.

The Ultra-class SoCs are two Max-class SoCs connected via
Apple's fabric, and thus use the same core revisions as the
Max-class SoCs for both big and LITTLE cores.

Signed-off-by: James Calligeros <[email protected]>
Copy link
Member

@Sonicadvance1 Sonicadvance1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that Apple uses the Part number to represent different SoC's cores but sure.

Thanks for the patch!

@chadmed
Copy link
Contributor Author

chadmed commented Sep 1, 2024

The core variants in each SoC seem to be subtly different designs with silicon bug fixes and such. The M1 Pro Firestorm and Icestorm need different chicken bits set compared to the base M1, for example.

@Sonicadvance1 Sonicadvance1 merged commit 8296bfc into FEX-Emu:main Sep 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants