HostFeatures: Removes vixl usage #3962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
force-pushed
the
remove_vixl_requirement
branch
4 times, most recently
from
2fa24da to
fceb1ff
Compare
lioncash
approved these changes
Aug 16, 2024
Sonicadvance1
force-pushed
the
remove_vixl_requirement
branch
from
fceb1ff to
2792e40
Compare
alyssarosenzweig
approved these changes
Aug 16, 2024
Sonicadvance1
force-pushed
the
remove_vixl_requirement
branch
from
2792e40 to
ccbb75b
Compare
If we query the CPU flags ourselves then vixl is no longer a compile-time or runtime dependency unless the vixl disassembler or simulator is built. A bit spicy from all the feature bits we need to load up.
Sonicadvance1
force-pushed
the
remove_vixl_requirement
branch
from
ccbb75b to
40d12c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we query the CPU flags ourselves then vixl is no longer a
compile-time or runtime dependency unless the vixl disassembler or
simulator is built.
A bit spicy from all the feature bits we need to load up.