CPUID: Removes FEX version string from CPU model name #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
approved these changes
May 1, 2024
Moves it to the hypervisor leafs. Before: ```bash $ FEXBash 'cat /proc/cpuinfo | grep "model name"' model name : FEX-2404-101-gf9effcb Cortex-A78C model name : FEX-2404-101-gf9effcb Cortex-A78C model name : FEX-2404-101-gf9effcb Cortex-A78C model name : FEX-2404-101-gf9effcb Cortex-A78C model name : FEX-2404-101-gf9effcb Cortex-X1C model name : FEX-2404-101-gf9effcb Cortex-X1C model name : FEX-2404-101-gf9effcb Cortex-X1C model name : FEX-2404-101-gf9effcb Cortex-X1C ``` After: ```bash $ FEXBash 'cat /proc/cpuinfo | grep "model name"' model name : Cortex-A78C model name : Cortex-A78C model name : Cortex-A78C model name : Cortex-A78C model name : Cortex-X1C model name : Cortex-X1C model name : Cortex-X1C model name : Cortex-X1C ``` Now the FEX string is in the hypervisor functions as a leaf, so if some utility wants the FEX version they can query that directly Ex: ```bash $ ./Bin/FEXInterpreter get_cpuid_fex Maximum 4000_0001h sub-leaf: 2 We are running under FEX on host: 2 FEX version string is: 'FEX-2404-113-g820494d' ```
Sonicadvance1
force-pushed
the
move_fex_versionstring_cpuid
branch
from
9e0aa18 to
31341bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves it to the hypervisor leafs.
Before:
After:
Now the FEX string is in the hypervisor functions as a leaf, so if some utility wants the FEX version they can query that directly
Ex:
$ ./Bin/FEXInterpreter get_cpuid_fex Maximum 4000_0001h sub-leaf: 2 We are running under FEX on host: 2 FEX version string is: 'FEX-2404-113-g820494d'