ConstProp: stop pooling inline constants

despite conventional wisdom, the robin map is slower than emitting extra nodes. without multiblock, shaves around 2% off node. with multiblock, a bit less than 1% but still a win. Signed-off-by: Alyssa Rosenzweig <[email protected]>
FEX-Emu · Sep 5, 2024 · e81a9aa · e81a9aa
1 parent 8fe1e95
commit e81a9aa
Showing 1 changed file with 1 addition and 11 deletions.
diff --git a/FEXCore/Source/Interface/IR/Passes/ConstProp.cpp b/FEXCore/Source/Interface/IR/Passes/ConstProp.cpp
@@ -16,7 +16,6 @@ desc: ConstProp, ZExt elim, const pooling, fcmp reduction, const inlining
 #include <FEXCore/Utils/LogManager.h>
 #include <FEXCore/Utils/Profiler.h>
 #include <FEXCore/fextl/map.h>
-#include <FEXCore/fextl/robin_map.h>
 #include <FEXCore/fextl/unordered_map.h>
 
 #include <bit>
@@ -79,15 +78,8 @@ class ConstProp final : public FEXCore::IR::Pass {
 
   fextl::unordered_map<uint64_t, Ref> ConstPool;
 
-  // Pool inline constant generation. These are typically very small and pool efficiently.
-  fextl::robin_map<uint64_t, Ref> InlineConstantGen;
   Ref CreateInlineConstant(IREmitter* IREmit, uint64_t Constant) {
-    const auto it = InlineConstantGen.find(Constant);
-    if (it != InlineConstantGen.end()) {
-      return it->second;
-    }
-    auto Result = InlineConstantGen.insert_or_assign(Constant, IREmit->_InlineConstant(Constant));
-    return Result.first->second;
+    return IREmit->_InlineConstant(Constant);
   }
   bool SupportsTSOImm9 {};
   const FEXCore::CPUIDEmu* CPUID;
@@ -577,8 +569,6 @@ void ConstProp::ConstantPropagation(IREmitter* IREmit, const IRListView& Current
 }
 
 void ConstProp::ConstantInlining(IREmitter* IREmit, const IRListView& CurrentIR) {
-  InlineConstantGen.clear();
-
   for (auto [CodeNode, IROp] : CurrentIR.GetAllCode()) {
     switch (IROp->Op) {
     case OP_LSHR: