feat!: autosave 添加开关选项，默认关闭 #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for v-editor ready! Built with commit 9d38131 |
|
为啥不是 autosave ：false 关闭该特性
|
已经有一个名为 autosave 的 emit 时间，如果重名的化容易产生歧义 |
levy9527
requested changes
Sep 1, 2020
auto-add-label
bot
added
breaking-change
and removed
enhancement
levy9527
reviewed
Sep 2, 2020
src/v-editor.vue
Outdated
| @@ -102,9 +104,12 @@ export default { | |||
| /** | |||
| * 关闭 autosave 功能，详见文档[Getting and saving data - CKEditor 5 Documentation](https://ckeditor.com/docs/ckeditor5/latest/builds/guides/integration/saving-data.html#autosave-feature) | |||
There was a problem hiding this comment.
这个注释，应该说明，默认是关闭。可传 true 或 ms
src/v-editor.vue
Outdated
| @@ -38,6 +38,8 @@ import CKEditor from '@ckeditor/ckeditor5-vue' | |||
| import fullScreenIcon from './assets/fullscreen.vue' | |||
| import fullScreenExitIcon from './assets/fullscreenexit.vue' | |||
|
|
|||
| const DEFAULT_AUTOSAVE_WAITING_TIME = 8000 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
需要控制 autosave 的开关
How
由于之前版本组件中autosave为自动打开的，所以提供一个 disable-autosave 的 prop
根据文档，可用autosave 的 waitingTime 代替 debounce 函数。
由于waitingTime默认值为1000ms，原使用debounce函数的方式会导致默认autosave时间不准确（9s）
Docs