Fix the plugin setup #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2024 16:55
- Distinguish between parser reference and entry point reference - TODO: fix `m_annotations` overloading
ladinesa
reviewed
Jul 3, 2024
| xml_parser = XMLParser(filepath='vasprun.xml') # TODO apply match | ||
| xml_parser.convert(archive_parser) | ||
| archive.data = archive_parser.data_object | ||
| logger.info('VasprunXMLParser.parse', parameter=configuration.parameter) |
There was a problem hiding this comment.
if this is a matching parsee you would meed to.add parsee specs
There was a problem hiding this comment.
You mean like the filename to match? I already added it to XMLParser
|
I think this shouldalready work. |
Me too. |
ladinesa
reviewed
Jul 3, 2024
|
|
||
|
|
||
| Program.name.m_annotations['xml'] = MappingAnnotationModel( | ||
| path='.i[?"@name"="program"]' |
There was a problem hiding this comment.
pls try to use simgle quotes inside somerimes jnespath is crazy and it should be ==
ladinesa
reviewed
Jul 3, 2024
|
|
||
|
|
||
| Program.version.m_annotations['xml'] = MappingAnnotationModel( | ||
| path='.i[?"@name"="version"]' |
ladinesa
reviewed
Jul 3, 2024
|
|
||
| # ? compilation mode | ||
| Program.compilation_host.m_annotations['xml'] = MappingAnnotationModel( | ||
| path='.i[?"@name"="platform"]' |
|
Mostly fixed, but have to close this branch for the upcoming tutorial. Will revisit in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the example in https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR/-/merge_requests/1655/
Before merging, make sure to add the full extraction.