Implemented separate 'Moderator Event' tab as per Issue #200 #201
Conversation
…mons from deb598d to 6e46109
- Renamed the method to better reflect its specific use case and to improve readability
This is possible, we'll do that in the next iteration 😃 ! |
| sourceCompatibility = '17' | ||
| sourceCompatibility = '21' |
There was a problem hiding this comment.
If the source compatibility is updated then we need to update the github action as well. This may also require updating gradle
| @@ -60,6 +60,9 @@ | |||
| <TextArea fx:id="chatLogTextArea" editable="false" prefHeight="200.0" prefWidth="200.0"/> | |||
| </content> | |||
| </Tab> | |||
| <Tab text="Moderator Event"> | |||
| <TextArea fx:id="moderatorEventTextArea" editable="false" prefHeight="200.0" prefWidth="200.0"/> | |||
There was a problem hiding this comment.
Do we want this to just be a text area or should it be a list box?
There was a problem hiding this comment.
Text area allows moderators to copy/paste it into their AI assistants 😃
There was a problem hiding this comment.
yep good point. I always forget about that weakness of javafx
This PR addresses Issue #200 by adding a separate 'Moderator Event' tab next to the 'Chat log'.
Changes include:
These changes allow moderators to view moderator-specific events entirely separate from the chat log. Currently, it is very basic and more a "proof of concept", but it is a great start to be extended in the future.
Thanks for the detailed issue description @Garanas
Thanks in advance for your code review @Brutus5000 or @Sheikah45
Fixes #200
Note: Player name is currently the raw represented focus army. I assume further changes to 'parseModeratorEvent' at faf-java-commons are needed to reference it to a player name. If the name can already be obtained from the current data, then please correct me.
Result in UI: