Release texture after use #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hdt80bro
reviewed
Oct 2, 2024
Hdt80bro
reviewed
Oct 5, 2024
| asm("call 0x004260B0;" : : [t] "a"(t) : "edx", "ecx"); | ||
| void *ReleaseTexture(Texture *t) { | ||
| void *__result; | ||
| asm("call 0x004260B0;" : "=a"(__result) : [t] "a"(t) : "edx", "ecx"); |
There was a problem hiding this comment.
Function 0x004260B0 doesn't return anything
There was a problem hiding this comment.
Yes, but it alters eax register. I'm not sure how compiler may behave without return value, since it is different from argument.
There was a problem hiding this comment.
And you can't put it in clobbers eaither
Garanas
force-pushed
the
ReleaseTexture
branch
from
c55785a
to
093cae8
Compare
Garanas
force-pushed
the
ReleaseTexture
branch
from
093cae8
to
6c445eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unreleased texture in custom world rendering.