Add multiprocessing capability to make_image.py #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwright
reviewed
Apr 26, 2021
| """ | ||
| Multithreaded version of self.make_images | ||
| """ | ||
| from multiprocessing import Pool |
There was a problem hiding this comment.
multiprocessing was imported above?
There was a problem hiding this comment.
Other than that it looks promising to me. A few things to check:
- Can it run under python27 still ?
- Does it work for both fork and spawn based processes (e.g. linux vs mac+windows) ?
- Could there be a simple testcase script that runs some cases in test/ ands checks the results do not change ? For example, the md5 hashes for the created frames match each other.
If you are confident we can merge now and fix a problem if someone finds one
Thanks!!!
|
Hi @jonwright, I am seeing it now :-) I had a look at @jadball's multiprocessing capability - and from a look at the code it looks fine. Unfortunately, I am quite new to this Github universe and is far from mastering it, so I haven't managed to "checkout" this new version for a test yet. Hopefully I will manage shortly and can thereafter merge @jadball's fork into master. PS: Thanks @jadball for helping out improving the code 🙏 |
osholm
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added multiprocessing capability to make_image.py
Moves everything after
for i in no_frames:into a separate function (make_one_frame).As each frame is independent (unless peakshape is 2) the
make_one_framefunction, it usespoolcontextfrom here to run the function on multiple processes.