-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix bug with specifying frame in frelon seg gui
- Loading branch information
Showing
1 changed file
with
13 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3eb8107
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi James,
Just to give you some feedbacks about your very new updates on the notebook.
Seen with user measurement data, found two small issues:
cf_4d.parameters.loadparameters(par_file)
cf_4d.updateGeometry()
before ucell = ImageD11.unitcell.unitcell_from_parameters(cf_4d.parameters)
It seems cf_4d = ds.get_cf_4d() does not get parameters. Probably this is because ds does not contain parameters any more.
write_h5(ds.grainsfile, grainsinos, overwrite_grains=False) currently has a different key from the old version which uses "write_grains_too" ?
So I guess the notebook needs to be updated to the new key name.
Cheers,
Haixing