Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build docker image and push to ECR #9

Merged
merged 8 commits into from
Apr 19, 2022
Merged

chore: build docker image and push to ECR #9

merged 8 commits into from
Apr 19, 2022

Conversation

birme
Copy link
Contributor

@birme birme commented Apr 19, 2022

This PR is part of #8 and addresses the part of building docker image and push to container registry on AWS. It also adds that unit tests are run on every push.

@birme birme requested a review from Sgtfishtank April 19, 2022 09:39
Copy link
Contributor

@Sgtfishtank Sgtfishtank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the tests that where incorrect.
LGTM

@birme birme merged commit c3954ab into main Apr 19, 2022
@birme birme deleted the ci/dockerfile branch April 19, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants