Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#54): period baseUrl isn't used #55

Merged
merged 2 commits into from
Feb 15, 2024
Merged

fix(#54): period baseUrl isn't used #55

merged 2 commits into from
Feb 15, 2024

Conversation

bwallberg
Copy link
Contributor

@bwallberg bwallberg commented Feb 15, 2024 •
edited
Loading

Fixes #54

@bwallberg
Copy link
Contributor Author

Trying to find a testvector to add so I can create some unit tests as well

birme
birme approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zapfire88
Copy link
Contributor

LGTM!

@bwallberg bwallberg merged commit 8f2d8b9 into main Feb 15, 2024
5 checks passed
@bwallberg bwallberg deleted the feat/54_handle-period-baseurl branch February 15, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birme birme birme approved these changes

@VolcanoCookies VolcanoCookies Awaiting requested review from VolcanoCookies

@zapfire88 zapfire88 Awaiting requested review from zapfire88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle baseURL in Dash-periods
3 participants
@bwallberg @zapfire88 @birme