-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transfer window deadlock with Qt, implement Window::doneCurrent() #484
Conversation
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Hold on with merge. The tfer window creation in tfer thread does not work with WGL. Share context must not be current, which was guaranteed by making the tfer context current in the draw thread. Now the draw context is current while sharing with the tfer context in tfer thread. Needs more work it seems... |
bool stopRunning() override { return _stop; } | ||
void postStop() { _stop = true; } | ||
|
||
private: | ||
const eq::Pipe* _pipe; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_pipe still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in run(): LB_TS_THREAD( _pipe->_tferThread );
Just did some archaeology: I should not introduce bug #177 again. Shared context creation must remain in the render thread. |
Updated |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
retest this please |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
retest this please |
Refer to this link for build results (access rights to CI server needed): |
+1 |
Fix transfer window deadlock with Qt, implement Window::doneCurrent()
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
No description provided.