-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dialog tracking to use tags & call_id #112
Conversation
Fix #96 |
5d7bda4
to
7664f86
Compare
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 73.62% 71.48% -2.15%
==========================================
Files 15 15
Lines 1547 1487 -60
Branches 267 256 -11
==========================================
- Hits 1139 1063 -76
- Misses 298 316 +18
+ Partials 110 108 -2
Continue to review full report at Codecov.
|
90ce81a
to
ae520ef
Compare
I'm missing something here, what updates the dialog structure with the To tag once its been set? |
Commented the proxy test for now as I'm working on proxying in a separate branch Added async-timeout in dev requirements as it's useful for testing & debugging
Do not merge yet. I'd like to do some more test after the rebase |
Yeah I thought about that. In the future the original message |
I think it might make sense to hide the original message and pull useful information out of the And in that case, it might make it easier to refactor if its turns out we can't put the tag on the message immediately - have it in the Request object instead. I mean, in theory, we can do SIP forking (see #100) inside a single endpoint - an INVITE comes in and we send two distinct responses each with a different tag. Maybe the best API for this is to be able to fork the request object.... |
@moises-silva ^ ping if you don't mind. |
Removed some more proxy stuff since it's not working. |
Added async-timeout in dev requirements
as it's useful for testing & debugging