Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Wizard from vaccination-app #41

Merged
merged 4 commits into from
Jul 1, 2019
Merged

Import Wizard from vaccination-app #41

merged 4 commits into from
Jul 1, 2019

Conversation

SferaDev
Copy link
Contributor

@SferaDev SferaDev commented Jun 11, 2019 •
edited
Loading

No description provided.

@SferaDev SferaDev mentioned this pull request Jun 13, 2019
Merged
@SferaDev SferaDev requested review from tokland and adrianq June 27, 2019 07:39
@SferaDev SferaDev self-assigned this Jun 27, 2019
tokland
tokland reviewed Jun 27, 2019
View reviewed changes
Copy link
Contributor

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works without problems. I guess we should add it to the README.

@tokland
Copy link
Contributor

tokland commented Jun 28, 2019

Added a couple of commits, one about i18n, the other about the problem @SferaDev reported. Finally, it was a bug in nano-memoize v1.1.3:

anywhichway/nano-memoize#7

@SferaDev SferaDev requested a review from tokland June 28, 2019 18:43
@adrianq adrianq merged commit f77e33d into master Jul 1, 2019
@SferaDev SferaDev deleted the feature/wizard branch July 1, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianq adrianq Awaiting requested review from adrianq

@tokland tokland Awaiting requested review from tokland

Assignees

@SferaDev SferaDev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SferaDev @tokland @adrianq