NMR

[p3rcypj]

📌 References

• Issue: Closes https://app.clickup.com/t/865ca9vp8

📝 Implementation

Added NMR Dialog with a list of the NMR fragments of each Target. Added two loaders and a pagination. On first glance, a simple request is made to retrieve the 25 first fragments and the count of them to be able to build the pagination. Later, each time the page is changed, it will trigger a new request to the API. An "Export all fragments" function has been added: it will first get the pagination count, in order to build all the needed requests to fullfill all the fragments of the target sequentially.

🎨 Screenshots

🔥 Testing

Please note the feature of being able to cancel the "export all fragments" request.

[tokland]

The code looks very good! Just some comments line:

[tokland]

This save does not belong to NMRApiRepository, note how we are not using the api. In the past, we'd create some export repository + a JSON data implementation. However, Jorge's advice is not to have import/export features as repositories, instead do it in the presentation (webapp, script) layer. So the use case simply gets the entity values (getNMRTarget) and the generation of the JSON+save is done in the react app (to keep it clean, in a different file, but in the presentation layer)