Allow upload model #103
Merged
Allow upload model #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianq
changed the base branch from
feature/right-panel-contents
to
development
…NOTES into feature/upload-in-search
tokland
requested changes
Mar 23, 2021
app/assets/javascripts/3dbio_viewer/src/domain/usecases/UploadAtomicStructureUseCase.ts
Outdated
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/webapp/components/dropzone/Dropzone.tsx
Outdated
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/webapp/components/model-upload/ModelUpload.tsx
Outdated
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/webapp/components/model-upload/ModelUpload.tsx
Outdated
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/data/repositories/EbiDbModelRepository.ts
Outdated
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/webapp/components/model-upload/ModelUpload.tsx
Outdated
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/webapp/components/model-upload/ModelUpload.tsx
Outdated
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/webapp/pages/app/App.css
Outdated
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/webapp/components/model-upload/ModelUpload.tsx
Outdated
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/webapp/components/model-upload/ModelUpload.tsx
Show resolved
Hide resolved
tokland
reviewed
Mar 23, 2021
app/assets/javascripts/3dbio_viewer/src/webapp/components/dropzone/Dropzone.tsx
Outdated
Show resolved
Hide resolved
tokland
approved these changes
Mar 25, 2021
| <label className="fileFormat">{i18n.t("Upload your annotations")}</label> | ||
| <Dropzone ref={annotationFileRef} accept={"application/json"}></Dropzone> | ||
|
|
||
| <button className="uploadSubmit" onClick={useCallbackEffect(onSubmitHandler)}> |
There was a problem hiding this comment.
Hook calls should be outside jsx blocks, so const submit = useCallbackEffect(onSubmitHandler). It's not only cleaner but also necessary, hooks must be executed always in the same order, and that JSX tag could be inside a conditional.
| const structureFileRef = useRef<DropzoneRef>(null); | ||
| const annotationFileRef = useRef<DropzoneRef>(null); | ||
|
|
||
| const onSubmitHandler = useCallback(() => { |
There was a problem hiding this comment.
[good practices comment] The prop is called onSubmitHandler, that's ok, it's a generic function, but here we know what it does, so let's use a more declarative name on what it does. For example: const search = ....
| @@ -47,6 +54,10 @@ export class EbiDbModelRepository implements DbModelRepository { | |||
| .value() | |||
| ); | |||
| } | |||
| upload(options: UploadOptions): FutureData<unknown> { | |||
| const uploadResults = request(config.upload.searchUrl, options); | |||
There was a problem hiding this comment.
We'll need a multipart/form-data POST to actually post these files, but let's leave this for the next PR, as here we concern ourselves mainly with the UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
🎨 Screenshots
🔥 How to test it? (If there is any special consideration or the reviewer does not know how to test it)
📑 Others