Updates component imports to full path #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosschapman
commented
Nov 7, 2024
app/App.tsx
Outdated
| @@ -4,14 +4,16 @@ import React, { useEffect, useState } from "react"; | |||
| // https://support.google.com/analytics/answer/12938611#zippy=%2Cin-this-article | |||
| import ReactGA_4 from "react-ga4"; | |||
| import { Helmet } from "react-helmet-async"; | |||
| import { useLocation, useNavigate } from "react-router-dom"; | |||
There was a problem hiding this comment.
note: unused var
adriencyberspace
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually necessary to fix tests from breaking, which was never a concern before we started writing them. The underlying module loading that happens when running tests will attempt to load every component in the index.ts file. This can cause the test to break because the test has not setup all the context and state for some of the other components in the index.ts file to work. For example, a newly added test in this PR requires this change.
I'm not sure why the code was written this way originally. It's quite old. It may have been an early react organization pattern.