[OUR415-313] Adds prop/slot for the "Clear Search" button in the SearchResults component
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosschapman
commented
Nov 7, 2024
| @@ -2,7 +2,6 @@ import React, { forwardRef } from "react"; | |||
| import { TransformedSearchHit } from "models"; | |||
| import { Link } from "react-router-dom"; | |||
| import { LabelTag } from "components/ui/LabelTag"; | |||
| import { Tooltip } from "react-tippy"; | |||
There was a problem hiding this comment.
note: Noticed this was unused.
| import { render, screen, waitFor } from "@testing-library/react"; | ||
| import SearchResults from "components/search/SearchResults/SearchResults"; | ||
| import { createSearchClient } from "../../../../test/helpers/createSearchClient"; | ||
| import ClearSearchButton from "components/search/Refinements/ClearSearchButton"; |
There was a problem hiding this comment.
chore: let's remove this line
| @@ -1,4 +1,4 @@ | |||
| import React, { useCallback } from "react"; | |||
| import React, { ReactNode, useCallback } from "react"; | |||
There was a problem hiding this comment.
chore: let's remove this too. notice we've let a lot of warnings through. i have some capacity and am happy to submit a PR to get rid of them
| @@ -30,7 +30,7 @@ interface Options { | |||
| * @param options Additional customizations of the search response | |||
There was a problem hiding this comment.
question (if-minor): Is this type any because it could be anything? Hoping to avoid type any as much as possible, and if it is needed, we should add a lint ignore comment (it wouldn't let me comment on the actual line (line 2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.