Upgrade canvas dependency to v2.6.1 - This fixes incompatibility with recent versions of node #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior version no longer works with newer versions of node
Package version upgrade introduced a breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is a bugfix.
Does this PR introduce a breaking change?
No.
Did you test your solution?
I ran
npm test. An MSDF image was successfully produced and written to the test folder.Problem Description
The version of canvas used in the current version of msdf-bmfont is incompatible with recent versions of node.
I encountered a similar error as was reported here, so I tried upgrading this package's version of canvas. It worked as hoped and now I am able to use msdf-bmfont.
Automattic/node-canvas#1501 (comment)
Solution Description
The version of the canvas package dependency has been updated to a version that is compatible with recent versions of node.
Side Effects, Risks, Impact
Node 6.x and lower will no longer be supported by this tool.
https://github.com/Automattic/node-canvas/blob/master/CHANGELOG.md#200
Aditional comments:
None.