Skip to content

Commit

Permalink
Merge pull request #6 from Expensify/Rory-UpdateTo18.7
Browse files Browse the repository at this point in the history
Update RNW to 18.7 - This was merged without signed commits as contributors upstream do not use signing.
  • Loading branch information
nathanmetcalf authored Aug 9, 2022
2 parents 3cd81b5 + 1a362eb commit 805f28a
Show file tree
Hide file tree
Showing 509 changed files with 34,901 additions and 17,566 deletions.
6 changes: 6 additions & 0 deletions .codesandbox/ci.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"packages": ["packages/react-native-web", "packages/babel-plugin-react-native-web"],
"buildCommand": "build",
"sandboxes": ["/packages/react-native-web-examples/"],
"node": "16"
}
17 changes: 0 additions & 17 deletions .flowconfig

This file was deleted.

84 changes: 31 additions & 53 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,97 +14,79 @@ Fork, then clone the repo:
git clone https://github.com/your-username/react-native-web.git
```

Install dependencies (requires [yarn](https://yarnpkg.com/en/docs/install)):
Install dependencies (requires Node.js >= 16.0):

```
yarn
npm install
```

## Automated tests
## Build

To run the linter:
Build a specific package:

```
yarn lint
npm run build -w <package-name>
```

To run flow:
For example, this will build `react-native-web`:

```
yarn flow
npm run build -w react-native-web
```

To run the unit tests:
Build all packages that can be built:

```
yarn jest
npm run build
```

…in watch mode:
## Develop

```
yarn jest --watch
```

To run all these automated tests:
Develop a specific package:

```
yarn test
npm run dev -w <package-name>
```

## Compile and build

To compile the `react-native-web` source code:
For example, this command will watch and rebuild the `react-native-web` package:

```
yarn compile
npm run dev -w react-native-web
```

…in watch mode:
And this command will watch and rebuild the `react-native-web-examples` package:

```
yarn compile --watch
npm run dev -w react-native-web-examples
```

## Documentation
## Test

To run the documentation website:
Run the monorepo linter:

```
yarn docs
npm run lint
```

## Examples

To run the examples app:
Run the monorepo type checker:

```
yarn examples
npm run flow
```

When you're also making changes to the 'react-native-web' source files, run this command in another process:
Run the monorepo unit tests:

```
yarn compile --watch
npm run unit
```

## Benchmarks

To run the benchmarks locally:
Run all the automated tests:

```
yarn benchmarks
open ./packages/benchmarks/dist/index.html
npm run test
```

To develop against these benchmarks:

```
yarn compile --watch
yarn benchmarks --watch
```

### New Features
## New Features

Please open an issue with a proposal for a new feature or refactoring before starting on the work. We don't want you to waste your efforts on a pull request that we won't want to accept.

Expand All @@ -115,19 +97,15 @@ Please open an issue with a proposal for a new feature or refactoring before sta
1. Fork the repository and create your branch from `master`.
2. If you've added code that should be tested, add tests!
3. If you've changed APIs, update the documentation.
4. Ensure the tests pass (`yarn test`).
4. Ensure the tests pass (`npm run test`).

You should see a pre-commit hook run before each commit. If it does not, you may need to reset you Git hookspath:

```
git config --unset core.hookspath
```
You should see a pre-commit hook run before each commit.

You can now submit a pull request, referencing any issues it addresses.

Please try to keep your pull request focused in scope and avoid including unrelated commits.

After you have submitted your pull request, we'll try to get back to you as soon as possible. We may suggest some changes or improvements.
After you have submitted your pull request, it's recommended that **you** perform the first code review. We'll try to get back to you as soon as possible and may suggest changes.

Thank you for contributing!

Expand All @@ -136,11 +114,11 @@ Thank you for contributing!
To commit, publish, and push a final version:

```
yarn release <version>
npm run release -- <version> --opt=<opt-code>
```

Release candidates or versions that you'd like to publish to npm, but do not want to produce a commit and push it to GitHub:

```
yarn release <version> --skip-git
npm run release -- <version> --skip-git
```
52 changes: 0 additions & 52 deletions .github/ISSUE_TEMPLATE/bug.md

This file was deleted.

48 changes: 48 additions & 0 deletions .github/ISSUE_TEMPLATE/bug.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
name: Bug report
description: File a bug report
labels: ["bug"]
body:
- type: markdown
attributes:
value: |
Thank you for reporting an issue! Create a test case for your issue by forking this template https://codesandbox.io/s/6lx6ql1w5r
- type: checkboxes
attributes:
label: Is there an existing issue for this?
description: Please search to see if an issue already exists for the bug you encountered.
options:
- label: I have searched the existing issues
required: true
- type: textarea
attributes:
label: Describe the issue
description: Please provide a concise description of what you're experiencing. Providing screenshots is also helpful.
validations:
required: true
- type: textarea
attributes:
label: Expected behavior
description: Please provide a concise description of what you expected to happen.
validations:
required: true
- type: textarea
attributes:
label: Steps to reproduce
description: Please describe the precise steps needed to reproduce the behavior.
placeholder: |
Mention package versions and environment (browser, etc)...
1. ...
2. ...
validations:
required: true
- type: input
attributes:
label: Test case
description: Please provide a link to a reduced test case that reproduces the issue.
placeholder: "https://codesandbox.io/s/6lx6ql1w5r"
validations:
required: true
- type: textarea
attributes:
label: Additional comments
description: You're welcome to provide additional context and proposed solutions.
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
blank_issues_enabled: false
17 changes: 0 additions & 17 deletions .github/ISSUE_TEMPLATE/feature.md

This file was deleted.

21 changes: 21 additions & 0 deletions .github/ISSUE_TEMPLATE/feature.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Feature request
description: If you have a suggestion…
labels: ["enhancement"]
body:
- type: markdown
attributes:
value: |
Thank you for suggesting a feature!
- type: checkboxes
attributes:
label: Is there an existing request?
description: Please search open and closed issues to see if this request has already been made.
options:
- label: I have searched for this request
required: true
- type: textarea
attributes:
label: Describe the feature request
description: Please provide a concise description of the request, potential solutions, and addtional context.
validations:
required: true
20 changes: 20 additions & 0 deletions .github/workflows/react-integration.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: react@next integration

on:
schedule:
# Run every Monday at 12:00 (see https://crontab.guru)
- cron: '0 12 * * 1'

jobs:
react-next:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: '16.x'
- run: npm install
# Update react-native-web to use react@next
- run: npm install react@next react-dom@next -w react-native-web
# Run the unit tests
- run: npm run unit
Loading

0 comments on commit 805f28a

Please sign in to comment.