Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example RN upgrade #228

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Example RN upgrade #228

wants to merge 5 commits into from
+3,190 −3,089

Conversation

gedu
Copy link
Contributor

@gedu gedu commented Dec 27, 2024

Details

Increased the RN version from 0.73 to 0.75

What this fixes

Keeps the Example updated given the lib react-native-qrcode-svg doesn't add the text-encoder lib for RN 0.75

Checklist

  • I have described the bug/issue
  • I have provided reproduction in Example App
  • I have tested that solution works on Example App on all platforms:
    • Android
    • iOS
    • Web

Screenshots/Videos

Screenshot 2024-12-26 at 14 08 50 Screenshot 2024-12-26 at 16 37 36 Screenshot 2024-12-27 at 09 53 21

This was referenced Dec 27, 2024
Open
Merged
@gedu
Copy link
Contributor Author

gedu commented Dec 27, 2024 •
edited
Loading

@mountiny Waiting for this PR to be merge first: #227

@parasharrajat
Copy link
Member

@mountiny Let's get this merged. Thanks.

@mountiny
Copy link
Contributor

@gedu @parasharrajat can you please remove the hold now and retest if needed

mountiny
mountiny reviewed Dec 27, 2024
View reviewed changes
Example/.gitignore Outdated Show resolved Hide resolved
@parasharrajat
Copy link
Member

@gedu Please merge main.

@parasharrajat
Copy link
Member

parasharrajat commented Dec 27, 2024 •
edited
Loading

Screenshots

🔲 iOS / native

28.12.2024_02.36.48_REC.mp4

🔲 MacOS / Chrome

28.12.2024_02.06.28_REC.mp4

🔲 Android / native

28.12.2024_02.08.43_REC.mp4

@mountiny mountiny changed the title [HOLD] Example RN upgrade Example RN upgrade Dec 28, 2024
@mountiny
Copy link
Contributor

@gedu please sync up with main

@gedu
Copy link
Contributor Author

gedu commented Dec 30, 2024

@mountiny done

@parasharrajat
Copy link
Member

Bump @mountiny

mountiny
mountiny previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gedu gedu dismissed mountiny’s stale review January 6, 2025 12:55

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parasharrajat parasharrajat parasharrajat approved these changes

@mountiny mountiny mountiny left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@gedu gedu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gedu @parasharrajat @mountiny