Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/tab leader write fix #434

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Feat/tab leader write fix #434

merged 3 commits into from
Dec 12, 2023

Conversation

koko57
Copy link
Contributor

@koko57 koko57 commented Dec 4, 2023

Details

#382 (comment)

Related Issues

GH_LINK #382

roryabraham
roryabraham previously approved these changes Dec 9, 2023
View reviewed changes
@roryabraham roryabraham mentioned this pull request Dec 9, 2023
Merged
@koko57
Copy link
Contributor Author

koko57 commented Dec 11, 2023

@roryabraham PR opened

@koko57 koko57 marked this pull request as ready for review December 11, 2023 07:55
@koko57 koko57 requested a review from a team as a code owner December 11, 2023 07:55
@melvin-bot melvin-bot bot requested review from grgia and removed request for a team December 11, 2023 07:55
grgia
grgia approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@grgia grgia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@roryabraham roryabraham merged commit 0aeae07 into Expensify:main Dec 12, 2023
4 checks passed
chrispader pushed a commit to margelo/react-native-onyx that referenced this pull request Jan 23, 2024
Revert "Merge pull request Expensify#434 from koko57/feat/tab_leader_…
c6a8377 
…write_fix"

This reverts commit 0aeae07, reversing
changes made to cc43294.
@chrispader chrispader mentioned this pull request Jan 23, 2024
Merged
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

@grgia grgia grgia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koko57 @grgia @roryabraham