-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent italic or strikethrough emojis on Android #534
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions in the comments, also a unit test suite would be much appreciated.
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownRange.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownRange.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please provide some unit tests in Java to verify the implementation.
Details
This PR fixes adding italics and strikethrough style to the emojis on Android and web platforms
Related Issues
Expensify/App#14676
Manual Tests
_🥰 test 😇 test 🥹_
# *~_🥰 test 😇 test 🥹_~*
Linked PRs