Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple text selection issues #377

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Fix multiple text selection issues #377

merged 1 commit into from
Jun 9, 2024

Conversation

ShridharGoel
Copy link
Contributor

@ShridharGoel ShridharGoel commented Jun 9, 2024 •
edited
Loading

Details

Fix multiple text selection issues caused by #370.

Related Issues

Expensify/App#43332
Expensify/App#43312
Expensify/App#43310

Testing steps:

  • Test mention by typing @ in chat.
  • Test emoji addition at the end of text.
  • Test editing comment by selecting text at the beginning of the comment and deleting it. It should not select some other text automatically.
  • All the above should work as expected.
Screen.Recording.2024-06-10.at.12.59.04.AM.mov

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ShridharGoel
Copy link
Contributor Author

@mountiny

@ShridharGoel
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA.

mountiny
mountiny approved these changes Jun 9, 2024
View reviewed changes
Copy link

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert to fix blocking issues

@mountiny mountiny merged commit e9424a9 into Expensify:main Jun 9, 2024
4 checks passed
This was referenced Jun 9, 2024
Closed
Closed
Closed
This was referenced Jun 10, 2024
Closed
Closed
This was referenced Jun 10, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mountiny mountiny mountiny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShridharGoel @mountiny