Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection prop #313

Merged

Conversation

Skalakid
Copy link
Collaborator

@Skalakid Skalakid commented Apr 15, 2024

Details

This PR fixes cursor position in following scenarios:

  • after entering emoji
  • after pasting text
  • after replacing text

Related Issues

Expensify/App#39360

Slack comment: https://swmansion.slack.com/archives/C06BDSWLDPB/p1712253259974309?thread_ts=1712171205.597509&cid=C06BDSWLDPB

Manual Tests

Linked PRs

@Skalakid Skalakid marked this pull request as ready for review April 18, 2024 14:18
@Skalakid Skalakid marked this pull request as draft April 18, 2024 14:35
@Skalakid Skalakid marked this pull request as ready for review April 23, 2024 06:36
Copy link
Collaborator

@BartoszGrajdek BartoszGrajdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine, let me test it 👀

src/web/cursorUtils.ts Outdated Show resolved Hide resolved
@Skalakid Skalakid merged commit 2220ea6 into main Apr 24, 2024
4 checks passed
@Skalakid Skalakid deleted the @Skalakid/fix-setting-cursor-position-by-selection-prop branch April 24, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants