Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding limit on how many times a crash command can run #2008

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Adding limit on how many times a crash command can run #2008

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
137df6b
adding limit
danieldoglas Dec 9, 2024
abb9d81
Merge branch 'main' into dsilva_preventSeveralCrashesFromHappening
danieldoglas Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions BedrockServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,6 +1172,12 @@ bool BedrockServer::_wouldCrash(const unique_ptr<BedrockCommand>& command) {
return false;
}

// If this command crashed with more than one set of identifying values, it means
// we've already crashed more than one node. Let's fully block this command in that case.
if (commandIt->second.size() > 1) {
return true;
}

// Look at each crash-inducing command that has the same methodLine.
for (const STable& values : commandIt->second) {

Expand Down
Loading