Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve issue with pdf attachment not being scrollable in preview page before sending on Android #6276

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Resolve issue with pdf attachment not being scrollable in preview page before sending on Android #6276

merged 1 commit into from
Nov 16, 2021

Conversation

eVoloshchak
Copy link
Contributor

@eVoloshchak eVoloshchak commented Nov 10, 2021 •
edited by Julesssss
Loading

Details

Fixed Issues

#5291

QA Steps

  1. Open application on an Android phone
  2. Navigate to any conversation
  3. Press "+" icon at the bottom left
  4. Select "Add attachment"
  5. Select "Choose document"
  6. Select a PDF file that has at least 2 pages
  7. Verify that file can be scrolled

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mp4

iOS

ios.MP4

Android

android.mp4

@eVoloshchak eVoloshchak requested a review from a team as a code owner November 10, 2021 18:37
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team November 10, 2021 18:37
Julesssss
Julesssss approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. Tests well on Android, Desktop & Web. Approving and holding.

@Julesssss Julesssss changed the title Resolve issue with pdf attachment not being scrollable in preview page before sending on Android [HOLD] Resolve issue with pdf attachment not being scrollable in preview page before sending on Android Nov 11, 2021
@mallenexpensify
Copy link
Contributor

Removed Company Offsite HOLD, feel free to merge @Julesssss

@Julesssss Julesssss changed the title [HOLD] Resolve issue with pdf attachment not being scrollable in preview page before sending on Android Resolve issue with pdf attachment not being scrollable in preview page before sending on Android Nov 16, 2021
@Julesssss Julesssss merged commit 8b26001 into Expensify:main Nov 16, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Nov 22, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Nov 29, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julesssss Julesssss Julesssss approved these changes

Assignees

@eVoloshchak eVoloshchak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eVoloshchak @mallenexpensify @OSBotify @Julesssss