Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start generating internal QA checklist with assignments #6102

Merged
merged 10 commits into from
Nov 10, 2021

Conversation

yuwenmemon
Copy link
Contributor

@yuwenmemon yuwenmemon commented Oct 28, 2021

Pullerbearing (@Jag96)
cc @roryabraham

Details

Adds a new Internal QA section to the Staging Deploy checklist for issues tagged "Internal QA"

Fixed Issues

$ #5195

Tests

  • Added automated tests

QA Steps

  • None, we'll have to test with a deploy.

@yuwenmemon yuwenmemon requested a review from a team as a code owner October 28, 2021 18:56
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team October 28, 2021 18:56
@yuwenmemon yuwenmemon changed the title [WIP] Start generating internal QA checklist without assignments [WIP] Start generating internal QA checklist with assignments Nov 8, 2021
@yuwenmemon yuwenmemon self-assigned this Nov 8, 2021
@yuwenmemon yuwenmemon changed the title [WIP] Start generating internal QA checklist with assignments Start generating internal QA checklist with assignments Nov 8, 2021
@yuwenmemon
Copy link
Contributor Author

Removing HOLD!

Jag96
Jag96 previously approved these changes Nov 9, 2021
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will let @roryabraham have a look as well

.github/libs/GithubUtils.js Outdated Show resolved Hide resolved
.github/libs/GithubUtils.js Outdated Show resolved Hide resolved
.github/libs/GithubUtils.js Outdated Show resolved Hide resolved
@roryabraham
Copy link
Contributor

@yuwenmemon You'll need to recompile actions and update the tests

@yuwenmemon
Copy link
Contributor Author

Yeah sorry bad internet - push was hanging

@roryabraham
Copy link
Contributor

LGTM, thanks @yuwenmemon. Should we hold this till next week?

@yuwenmemon
Copy link
Contributor Author

It's not consumer-facing so I don't see a need to 🤷

@roryabraham
Copy link
Contributor

Okay, sounds good. I'll merge as soon as tests pass.

@roryabraham roryabraham added the InternalQA This pull request required internal QA label Nov 10, 2021
@roryabraham roryabraham merged commit 2756657 into main Nov 10, 2021
@roryabraham roryabraham deleted the yuwen-internalQAChecklist branch November 10, 2021 15:41
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.14-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
InternalQA This pull request required internal QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants