-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade RN to 63.3 and remove patch package #580
Conversation
So reading the release notes: https://github.com/facebook/react-native/releases/tag/v0.63.3 It mentions using this tool: https://react-native-community.github.io/upgrade-helper/?from=0.62.2&to=0.63.3 to update. Should we apply those native changes as well? I think we probably do have to make those changes manually or by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in terms of reverting that patch 👍 but sounds like @roryabraham is suggesting we're missing some steps
@cead22 This is the first I've heard of it - maybe you were thinking of someone else? Only suggestion I have is to change testing step 0 to run |
Heh, sorry I meant to tag @AndrewGable, I don't know why I tagged you, I was referring to Andrew's comment above about the upgrade command |
@AndrewGable this upgrade is from 63.2 to 63.3, not 62.2 to 63.3: https://react-native-community.github.io/upgrade-helper/?from=0.63.2&to=0.63.3 But yes looks like the flipper upgrade wasn't pushed there, will update. |
Updated and re-tested after merging with master as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@timszot @cead22 will you please review this?
cc @tgolen @AndrewGable
When implementing #463, there was a bug with React Native version 0.63.2 that caused loading local images from the camera/library to fail: facebook/react-native#29364. To fix this issue, I added a patch using patch-package to temporarily patch the issue until the fix for the RN bug was released. 0.63.3 has been released, and it seems to have fixed the issue, so this PR reverts the patch-package change and updates RN to include the fix.
Fixed Issues
Related to #463
Tests
npm install; cd ios; pod install;
before testing. Also, if you're testing Android on an emulator, be sure to clean w/cd android && ./gradlew clean