-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Fix convert integration (one more time) #52505
Conversation
9c3f1b1
to
a119970
Compare
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
🎯 @allroundexperts, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #52506. |
…quotes [NoQA] Fix convert integration (one more time) (cherry picked from commit a4c3a4b) (CP triggered by francoisl)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…g-52505-1 🍒 Cherry pick PR #52505 to staging 🍒
🚀 Cherry-picked to staging by https://github.com/srikarparsi in version: 9.0.61-3 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.61-3 🚀
|
Explanation of Change
Replace curly quotes with straight quotes when inserting a
<script>
tag.Fixed Issues
Follow-up of https://github.com/Expensify/App/pull/52503/files
Tests
None according to https://expensify.slack.com/archives/C07RXNJDMC5/p1731538648379399?thread_ts=1731084040.934579&cid=C07RXNJDMC5
QA Steps
No QA
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop