Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KeyboardAvoidingView not aware of the keyboard closing after it is unmounted #51509

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Fix KeyboardAvoidingView not aware of the keyboard closing after it is unmounted #51509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
968c348
Fix KeyboardAvoidingView not aware of the keyboard closing after it i…
QichenZhu Oct 25, 2024
bb451f5
Rename the patch
QichenZhu Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions patches/react-native+0.75.2+020+keyboard-avoiding-view.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
diff --git a/node_modules/react-native/Libraries/Components/Keyboard/KeyboardAvoidingView.js b/node_modules/react-native/Libraries/Components/Keyboard/KeyboardAvoidingView.js
index e26d677..597be5a 100644
--- a/node_modules/react-native/Libraries/Components/Keyboard/KeyboardAvoidingView.js
+++ b/node_modules/react-native/Libraries/Components/Keyboard/KeyboardAvoidingView.js
@@ -175,6 +175,13 @@ class KeyboardAvoidingView extends React.Component<Props, State> {
}

componentDidMount(): void {
+ // Fix KeyboardAvoidingView not aware of the keyboard closing after it is unmounted.
+ // Remove this patch after the upstream fix https://github.com/facebook/react-native/commit/08bd8ac47da60121225e7b281bbf566e2c5a291e is released.
+ if (!Keyboard.isVisible()) {
+ this._keyboardEvent = null;
+ this._setBottom(0);
+ }
+
if (Platform.OS === 'ios') {
this._subscriptions = [
Keyboard.addListener('keyboardWillChangeFrame', this._onKeyboardChange),