Update and rename adding-payment-card-subscription-overview.md to Add… #50567

zanyrenney · 2024-10-10T13:09:56Z

…-a-payment-card-and-view-your-subcription.md

Added the images into the help site page and rename the title

https://github.com/Expensify/Expensify/issues/428744

Details

Fixed Issues

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…-a-payment-card-and-view-your-subcription.md Added the images into the help site page

melvin-bot · 2024-10-10T13:10:35Z

@dangrous Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dangrous

Couple of things:

I think this needs the default header, e.g.

---
title: Subscription Management
description: How to manage your subscription
---

or whatever

Also can we add some actual alt text for the images, instead of the placeholder Insert alt text for accessibility here haha? This is what would show on hover, or if they're using a screen reader.
The deploy is getting the error Articles have been renamed or deleted. Please add a redirect link for the old article links in redirects.csv so we'll need to do that too

Thanks!

Changed the image placeholders and updated the Title from Dan's review.

change the page link from: https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/adding-payment-card-subscription-overview to https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/add-a-payment-card-and-view-your-subcription

zanyrenney · 2024-10-10T18:02:45Z

Okay @dangrous redirects also updated! thank you!

OSBotify · 2024-10-10T18:07:24Z

A preview of your ExpensifyHelp changes have been deployed to https://f4f77522.helpdot.pages.dev ⚡️

dangrous

this looks good but one edit to the header and then I noticed that the url says subcription not subscription so that should be fixed in the name of the file AND in the redirects.

Everything else looks perfect though, sorry that I didn't catch that earlier!

...cles/new-expensify/billing-and-subscriptions/Add-a-payment-card-and-view-your-subcription.md

zanyrenney · 2024-10-11T09:08:06Z

Hmm this still doesn't look quite right @dangrous please don't merge yet

Need to delete that line!

zanyrenney · 2024-10-11T09:09:47Z

I have a full k2 so gonna do this next week

dangrous · 2024-10-11T13:50:27Z

no worries, I'm in no rush haha! As for that line accepting the suggestion here should make that go away

…yment-card-and-view-your-subscription.md misspelled subscription! Co-authored-by: Daniel Gale-Rosen <[email protected]>

zanyrenney · 2024-10-11T16:00:21Z

Okay @dangrous I accepted that suggestion and updated the title in there for my mistake to spell subscription right 🤪

zanyrenney · 2024-10-11T16:00:31Z

Now let me give that redirect page another edit !

misspelled subscription, updated in the file name and in the redirect.

zanyrenney · 2024-10-11T16:03:35Z

Okay I just had to get this off my plate 😂 so I think i have now done it all @dangrous fingers crossed, let me know!

zanyrenney · 2024-10-11T16:23:44Z

okay sad times again this looks weird

it should be like

Under the subscriptions section of your account, you can manage your payment card details, view your current plan, add a billing card, and adjust your subscription size and renewal date. To view or manage your subscription in New Expensify:
Open the App: Launch New Expensify on your device.
Go to Account Settings: Click your profile icon in the bottom-left corner.
Find Workspaces: Navigate to the Workspaces section.
Open Subscriptions: Click Subscription under Workspaces to view your subscription.

dangrous · 2024-10-14T15:53:16Z

I think for that formatting you want:

To view or manage your subscription in New Expensify:
* **Open the App**: Launch New Expensify on your device.
* **Go to Account Settings**: Click your profile icon in the bottom-left corner.
* **Find Workspaces**: Navigate to the Workspaces section.
* **Open Subscriptions**: Click Subscription under Workspaces to view your subscription.

(with the * s at the beginning for bullets)

But i'm not able to build this locally right now for some reason so I can't confirm.

…Add-a-payment-card-and-view-your-subscription.md updated to format line by line and title to be correct

zanyrenney · 2024-10-14T16:47:32Z

OK okay this should be good now 😂 @dangrous

dangrous

yayyyy!

dangrous · 2024-10-15T14:22:44Z

Oh wait nooooooooooo now there are conflicts, i was too slow!

can you click "Resolve conflicts" and then I think you should just be able to say "Accept both changes"

zanyrenney · 2024-10-15T17:00:12Z

WELP. Sorry I am confused. I have:

clicked resolve conflicts
am taken to this red/ yellow section but I don't see what I need to change?

dangrous · 2024-10-15T17:08:28Z

Okay I think the buttons I was talking about are from an extension I have. But still pretty easy. Basically in this case all you have to do is remove the weird looking lines, which you can do right from that view, and then click "Mark as resolved" at the top. So:

- <<<<<<< zanyrenney-patch-1
https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/adding-payment-card-subscription-overview,https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/add-a-payment-card-and-view-your-subscription
- =======
https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Send-Receive-for-Invoices,https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Send-and-Receive-Payment-for-Invoices.md
https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Bulk-Upload-Multiple-Invoices,https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Add-Invoices-in-Bulk
- >>>>>>> main

So sorry this keeps dragging!

(The reason for this is the first bit between the weird lines is your change, and the second bit between the lines is a change that has been made by someone else while this was going on. Sometimes that can be a "conflict", like if there was: variable = 3 and you changed it to variable = 2 and someone else changed it to variable = 1 at the same time. So you'd need to figure out which one you want to keep. In this case, it's basically saying that someone else added some things at the end, and you also added some things at the end. It doesn't know that it's totally fine for them to be in whatever order in this file, so it's asking you what you want to do. Which is just to keep everything.)

zanyrenney · 2024-10-16T13:06:27Z

Hey @dangrous

when you say remove the lines and then you pasted this:

<<<<<<< zanyrenney-patch-1
https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/adding-payment-card-subscription-overview,https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/add-a-payment-card-and-view-your-subscription

Do you mean I remove that whole output and replace it?

I'm still not sure what you're saying I am afraid. Please could you clarify

what I should remove?
What it should be replaced with?

dangrous · 2024-10-16T16:08:31Z

Yeah so literally delete just the three lines that were highlighted, so go from:

<<<<<<< zanyrenney-patch-1
https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/adding-payment-card-subscription-overview,https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/add-a-payment-card-and-view-your-subscription
=======
https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Send-Receive-for-Invoices,https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Send-and-Receive-Payment-for-Invoices.md
https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Bulk-Upload-Multiple-Invoices,https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Add-Invoices-in-Bulk
https://help.expensify.com/articles/expensify-classic/bank-accounts-and-payments/payments/Pay-Bills,https://help.expensify.com/articles/expensify-classic/bank-accounts-and-payments/payments/Create-and-Pay-Bills
>>>>>>> main

to

https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/adding-payment-card-subscription-overview,https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/add-a-payment-card-and-view-your-subscription
https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Send-Receive-for-Invoices,https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Send-and-Receive-Payment-for-Invoices.md
https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Bulk-Upload-Multiple-Invoices,https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Add-Invoices-in-Bulk
https://help.expensify.com/articles/expensify-classic/bank-accounts-and-payments/payments/Pay-Bills,https://help.expensify.com/articles/expensify-classic/bank-accounts-and-payments/payments/Create-and-Pay-Bills

zanyrenney

Dan updated the bullets, looks good!

zanyrenney · 2024-10-17T11:05:50Z

I accepted his changes, now final change is on the redirects, doing that now.

zanyrenney · 2024-10-17T11:08:44Z

Hey @dangrous those lines are no longer showing as

<<<<<<< zanyrenney-patch-1
https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/adding-payment-card-subscription-overview,https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/add-a-payment-card-and-view-your-subscription
=======
https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Send-Receive-for-Invoices,https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Send-and-Receive-Payment-for-Invoices.md
https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Bulk-Upload-Multiple-Invoices,https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Add-Invoices-in-Bulk
https://help.expensify.com/articles/expensify-classic/bank-accounts-and-payments/payments/Pay-Bills,https://help.expensify.com/articles/expensify-classic/bank-accounts-and-payments/payments/Create-and-Pay-Bills
>>>>>>> main

They only show as

https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/adding-payment-card-subscription-overview,https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/add-a-payment-card-and-view-your-subscription
https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Send-Receive-for-Invoices,https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Send-and-Receive-Payment-for-Invoices.md
https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Bulk-Upload-Multiple-Invoices,https://help.expensify.com/articles/expensify-classic/articles/expensify-classic/expenses/Add-Invoices-in-Bulk
https://help.expensify.com/articles/expensify-classic/bank-accounts-and-payments/payments/Pay-Bills,https://help.expensify.com/articles/expensify-classic/bank-accounts-and-payments/payments/Create-and-Pay-Bills

Did you already make the changes? sorry I am so confused over this PR now.

dangrous

i... have no idea how that went away. But it works for me! Finally!

dangrous · 2024-10-17T15:06:52Z

Argh wait no it's back - I think GitHub must have been confused? Can you try the same thing as above again? I also didn't see it but now I see it again

zanyrenney · 2024-10-18T11:08:07Z

I can't see the lines at all. I am gonna schedule a sync as this is a bit inefficient at this point and i just want to get it closed.

dangrous · 2024-10-18T13:48:58Z

Yeah I don't think it helps that GitHub seems to have some bugs. But yes, happy to sync! Let's get this over with haha

dangrous · 2024-10-21T18:13:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2024-10-22T04:48:06Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-23T16:25:33Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Update and rename adding-payment-card-subscription-overview.md to Add…

f24e618

…-a-payment-card-and-view-your-subcription.md Added the images into the help site page

zanyrenney requested a review from a team as a code owner October 10, 2024 13:09

melvin-bot bot requested review from dangrous and removed request for a team October 10, 2024 13:10

zanyrenney self-assigned this Oct 10, 2024

dangrous requested changes Oct 10, 2024

View reviewed changes

zanyrenney added 2 commits October 10, 2024 18:37

Update Add-a-payment-card-and-view-your-subcription.md

734faee

Changed the image placeholders and updated the Title from Dan's review.

dangrous requested changes Oct 10, 2024

View reviewed changes

...cles/new-expensify/billing-and-subscriptions/Add-a-payment-card-and-view-your-subcription.md Outdated Show resolved Hide resolved

Update docs/articles/new-expensify/billing-and-subscriptions/Add-a-pa…

dec9e98

…yment-card-and-view-your-subscription.md misspelled subscription! Co-authored-by: Daniel Gale-Rosen <[email protected]>

Update redirects.csv

02f55a8

misspelled subscription, updated in the file name and in the redirect.

Update and rename Add-a-payment-card-and-view-your-subcription.md to …

d8c5292

…Add-a-payment-card-and-view-your-subscription.md updated to format line by line and title to be correct

dangrous approved these changes Oct 15, 2024

View reviewed changes

zanyrenney commented Oct 17, 2024

View reviewed changes

dangrous previously approved these changes Oct 17, 2024

View reviewed changes

Merge branch 'main' into zanyrenney-patch-1

cfd93ef

zanyrenney dismissed dangrous’s stale review via cfd93ef October 21, 2024 18:12

dangrous approved these changes Oct 21, 2024

View reviewed changes

dangrous merged commit d808271 into main Oct 21, 2024
9 of 10 checks passed

dangrous deleted the zanyrenney-patch-1 branch October 21, 2024 18:15

github-actions bot mentioned this pull request Oct 22, 2024

Deploy Checklist: New Expensify 2024-10-22 #51219

Closed

74 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update and rename adding-payment-card-subscription-overview.md to Add… #50567

Update and rename adding-payment-card-subscription-overview.md to Add… #50567

zanyrenney commented Oct 10, 2024 •

edited

Loading

melvin-bot bot commented Oct 10, 2024

dangrous left a comment •

edited

Loading

zanyrenney commented Oct 10, 2024

OSBotify commented Oct 10, 2024 •

edited

Loading

dangrous left a comment

zanyrenney commented Oct 11, 2024 •

edited

Loading

zanyrenney commented Oct 11, 2024

dangrous commented Oct 11, 2024

zanyrenney commented Oct 11, 2024

zanyrenney commented Oct 11, 2024

zanyrenney commented Oct 11, 2024

zanyrenney commented Oct 11, 2024

dangrous commented Oct 14, 2024

zanyrenney commented Oct 14, 2024

dangrous left a comment

dangrous commented Oct 15, 2024

zanyrenney commented Oct 15, 2024

dangrous commented Oct 15, 2024 •

edited

Loading

zanyrenney commented Oct 16, 2024 •

edited

Loading

dangrous commented Oct 16, 2024

zanyrenney left a comment

zanyrenney commented Oct 17, 2024

zanyrenney commented Oct 17, 2024 •

edited

Loading

dangrous left a comment

dangrous commented Oct 17, 2024

zanyrenney commented Oct 18, 2024 •

edited

Loading

dangrous commented Oct 18, 2024

dangrous commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

Update and rename adding-payment-card-subscription-overview.md to Add… #50567

Update and rename adding-payment-card-subscription-overview.md to Add… #50567

Conversation

zanyrenney commented Oct 10, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 10, 2024

dangrous left a comment • edited Loading

Choose a reason for hiding this comment

zanyrenney commented Oct 10, 2024

OSBotify commented Oct 10, 2024 • edited Loading

dangrous left a comment

Choose a reason for hiding this comment

zanyrenney commented Oct 11, 2024 • edited Loading

zanyrenney commented Oct 11, 2024

dangrous commented Oct 11, 2024

zanyrenney commented Oct 11, 2024

zanyrenney commented Oct 11, 2024

zanyrenney commented Oct 11, 2024

zanyrenney commented Oct 11, 2024

dangrous commented Oct 14, 2024

zanyrenney commented Oct 14, 2024

dangrous left a comment

Choose a reason for hiding this comment

dangrous commented Oct 15, 2024

zanyrenney commented Oct 15, 2024

dangrous commented Oct 15, 2024 • edited Loading

zanyrenney commented Oct 16, 2024 • edited Loading

dangrous commented Oct 16, 2024

zanyrenney left a comment

Choose a reason for hiding this comment

zanyrenney commented Oct 17, 2024

zanyrenney commented Oct 17, 2024 • edited Loading

dangrous left a comment

Choose a reason for hiding this comment

dangrous commented Oct 17, 2024

zanyrenney commented Oct 18, 2024 • edited Loading

dangrous commented Oct 18, 2024

dangrous commented Oct 21, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

zanyrenney commented Oct 10, 2024 •

edited

Loading

dangrous left a comment •

edited

Loading

OSBotify commented Oct 10, 2024 •

edited

Loading

zanyrenney commented Oct 11, 2024 •

edited

Loading

dangrous commented Oct 15, 2024 •

edited

Loading

zanyrenney commented Oct 16, 2024 •

edited

Loading

zanyrenney commented Oct 17, 2024 •

edited

Loading

zanyrenney commented Oct 18, 2024 •

edited

Loading

dangrous commented Oct 21, 2024 •

edited

Loading