-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write platform specific mute settings to backend #50493
Merged
+53
−5
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1e138f9
write platform specific mute settings to backend
c3024 2595cb8
add types
c3024 e7d6547
Merge branch 'main' into write-mute-settings-to-backend
c3024 414b756
fix lint
c3024 172368d
prettier
c3024 97b8937
prettier and typecheck
c3024 91db435
Merge branch 'main' into write-mute-settings-to-backend
c3024 266996a
chnage mutedPlatforms to object
c3024 173b49d
Merge branch 'main' into write-mute-settings-to-backend
c3024 d7361f8
Merge branch 'main' into write-mute-settings-to-backend
c3024 683d536
Merge branch 'main' into write-mute-settings-to-backend
c3024 d072b8f
Merge branch 'main' into write-mute-settings-to-backend
c3024 d4a4ec5
rename API command param to platformToMute
c3024 a442467
enhanceParameters adds authToken to the parameters
c3024 be2f50a
Merge branch 'main' into write-mute-settings-to-backend
c3024 cb4e58e
subscribe to session correctly
c3024 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import type Platform from '@libs/getPlatform/types'; | ||
|
||
type TogglePlatformMuteParams = { | ||
platformToMute: Platform; | ||
}; | ||
|
||
export default TogglePlatformMuteParams; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to use
MERGE
here without passingmutedPlatforms
to this functiontogglePlatformMute
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For NVPs, the server uses SET, so it's probably best to use SET here as well. That will keep things consistent.