Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Saved search list is not scrollable when there is a long list #50244

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Fix: Saved search list is not scrollable when there is a long list #50244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/pages/Search/SearchPageBottomTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,12 @@ function SearchPageBottomTab() {
isCustomSearchQuery={shouldUseNarrowLayout && !SearchUtils.isCannedSearchQuery(queryJSON)}
/>
</View>
<Animated.View style={[styles.searchTopBarStyle, topBarAnimatedStyle]}>
<SearchTypeMenu
queryJSON={queryJSON}
searchName={searchName}
/>
{shouldUseNarrowLayout && (
{shouldUseNarrowLayout ? (
<Animated.View style={[styles.searchTopBarStyle, topBarAnimatedStyle]}>
<SearchTypeMenu
queryJSON={queryJSON}
searchName={searchName}
/>
<SearchStatusBar
type={queryJSON.type}
status={queryJSON.status}
Expand All @@ -116,8 +116,13 @@ function SearchPageBottomTab() {
topBarOffset.value = withTiming(variables.searchHeaderHeight, {duration: ANIMATION_DURATION_IN_MS});
}}
/>
)}
</Animated.View>
</Animated.View>
) : (
<SearchTypeMenu
queryJSON={queryJSON}
searchName={searchName}
/>
)}
</>
) : (
<SearchSelectionModeHeader queryJSON={queryJSON} />
Expand Down
Loading