[GH-47817]- remove messageManuallyMarkedUnread and manual handling of… #49367

klajdipaja · 2024-09-18T08:05:46Z

Details

This PR simplifies the logic related to the unread marker in the chat so that we can rely more on the unread state of the report actions from the backend instead of a local state.

Fixed Issues

$ #47817
PROPOSAL: #47817 (comment)

Tests

Mark unread user messages:

Open a chat with a workspace or another user
Send a few messages in the chat
Mark a message as unread
Open a different chat
Open the same chat again
Expected result: the "new message" marker line is shown on the message that was marked unread

Unread messages in thread

Open a chat with a workspace or another user
Send a message in the chat
Start a new thread in the chat and send a few messages
Mark one of the messages as unread
Leave thread
Open thread again
Expected result: the "new message" marker line is shown on the message that was marked unread

Unread messages between devices

Run all the steps for one of the previous tests in desktop app
Open a different device (mweb, android, ios)
Open same chat where you marked message unread
Expected result: the "new message" marker line is shown on the message that was marked unread

Offline tests

The first two cases can be tested as they are in offline mode. The third one would be as follows:

Run all the steps for one of the previous tests in device A
Open a different device (mweb, android, ios)
No unread messages would show from step 1 as the messages have not reached the backend yet
Make device A online and wait for the Mark Unread action to be sent online
Open the same chat where you marked message unread
Expected result: the "new message" marker line is shown on the message that was marked unread

QA Steps

PR Author Checklist

Screenshots/Videos

Android: Native

android_native_mark.unread2.mov

Android: mWeb Chrome

android.mweb.mark.unread.testing.mov

iOS: Native

ios.native.mark.unread.2.mov

iOS: mWeb Safari

ios.mweb.safari.mark.unread.testing.mov

MacOS: Chrome / Safari

MacOs-Chrome-mark-unread-testing2.mov

MacOS: Desktop

MacOs.Desktop-mar-unread-testing2.mov

…ndling of the unread marker so that we rely on the BE information about the last unread action

melvin-bot · 2024-09-18T08:05:52Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-09-18T08:06:00Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

klajdipaja · 2024-09-18T08:07:30Z

I have read the CLA Document and I hereby sign the CLA

arosiclair

This LGTM. Be sure the test steps from this PR also still work.

klajdipaja · 2024-09-18T15:38:41Z

@arosiclair thanks, I tested both the ones in the PR checklist and the ones in the comments and it tests well.

To the reviewer: The ESLint failures have nothing to do with what I changed, do I still need to solve them?

arosiclair · 2024-09-18T16:19:08Z

src/pages/home/report/ReportActionsList.tsx

@@ -245,19 +236,18 @@ function ReportActionsList({
        }

        return null;
-    }, [accountID, sortedVisibleReportActions, unreadMarkerTime, messageManuallyMarkedUnread]);
+    }, [accountID, sortedVisibleReportActions, unreadMarkerTime]);


Suggested change

}, [accountID, sortedVisibleReportActions, unreadMarkerTime]);

}, [sortedVisibleReportActions, unreadMarkerTime]);

Actually you should fix this

arosiclair · 2024-09-18T16:20:26Z

I'm not sure why there's an ESLint check on unchanged files, but I would think those do not need to be fixed. The failures in changed files do need to be fixed though.

…ary dependency

arosiclair

All yours @mollfpr. Not sure about the lint errors in other files, but I asked here.

mollfpr · 2024-09-19T15:36:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

49367.Android.mp4

Android: mWeb Chrome

49367.mWeb-Chrome.mp4

iOS: Native

49367.iOS.mp4

iOS: mWeb Safari

49367.mWeb-Safari.mp4

MacOS: Chrome / Safari

49367.Web.mp4

49367.Web.2.mp4

MacOS: Desktop

49367.Desktop.mp4

mollfpr

LGTM and tests well 👍

neil-marcellini

Looks good, thank you. I think we need to fix the ESLint checks though.

klajdipaja · 2024-09-23T17:13:05Z

@neil-marcellini based on this slack thread we should fix only errors in changed files

https://expensify.enterprise.slack.com/archives/C01GTK53T8Q/p1726758316863109?thread_ts=1726758316.863109&cid=C01GTK53T8Q

neil-marcellini · 2024-09-24T16:38:05Z

Ok, thanks so much for explaining @klajdipaja. Merging with the ESLint check failing because it's unrelated to these changes, and it's being handled in the PRs the contributor linked in that Slack message above.

melvin-bot · 2024-09-24T16:38:17Z

@neil-marcellini looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-09-24T16:49:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-24T19:30:08Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.40-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-09-27T17:45:03Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.40-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ikevin127 · 2024-11-04T23:47:57Z

The changes from this PR led to the following issue:

[HOLD for payment 2024-11-07] [$250] Chat: "Unread" marker appears when the user sends a new message #50469

because before the changes implemented in this PR, we were ignoring any message that the current user sends, unless the user marked it as unread manually.

To fix the issue we applied the solution from this proposal, read all the context from the contributor to better understand the issue and the solution implemented to fix it.

[ExpensifyGH-47817]- remove messageManuallyMarkedUnread and manual ha…

942876f

…ndling of the unread marker so that we rely on the BE information about the last unread action

klajdipaja requested a review from a team as a code owner September 18, 2024 08:05

melvin-bot bot requested review from mollfpr and removed request for a team September 18, 2024 08:05

arosiclair reviewed Sep 18, 2024

View reviewed changes

arosiclair requested changes Sep 18, 2024

View reviewed changes

remove accountID from memo to fix warning for useMemo has an unnecess…

3fce21f

…ary dependency

arosiclair approved these changes Sep 19, 2024

View reviewed changes

mollfpr approved these changes Sep 22, 2024

View reviewed changes

melvin-bot bot requested a review from neil-marcellini September 22, 2024 16:57

neil-marcellini approved these changes Sep 23, 2024

View reviewed changes

neil-marcellini merged commit 4953d89 into Expensify:main Sep 24, 2024
16 of 18 checks passed

melvin-bot bot added the Emergency label Sep 24, 2024

neil-marcellini removed the Emergency label Sep 24, 2024

github-actions bot mentioned this pull request Sep 24, 2024

Deploy Checklist: New Expensify 2024-09-24 #49662

Closed

67 tasks

bernhardoj mentioned this pull request Sep 25, 2024

[HOLD for payment 2024-10-04] [$250] Chat - New message line marker shown in the wrong position #49525

Closed

6 tasks

marcaaron mentioned this pull request Sep 25, 2024

Revert "[GH-47817]- remove messageManuallyMarkedUnread and manual handling of…" #49762

Closed

klajdipaja mentioned this pull request Sep 26, 2024

Thread – New message button and green line appears when go back to main chat from thread #49751

Closed

6 tasks

bernhardoj mentioned this pull request Oct 11, 2024

[HOLD for payment 2024-11-07] [$250] Chat: "Unread" marker appears when the user sends a new message #50469

Closed

6 tasks

klajdipaja deleted the bugfix/47817_Unread_marker_not_displayed_when_opening_thread_with_unread_comments branch November 1, 2024 13:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GH-47817]- remove messageManuallyMarkedUnread and manual handling of… #49367

[GH-47817]- remove messageManuallyMarkedUnread and manual handling of… #49367

klajdipaja commented Sep 18, 2024 •

edited

Loading

melvin-bot bot commented Sep 18, 2024

github-actions bot commented Sep 18, 2024 •

edited

Loading

klajdipaja commented Sep 18, 2024

arosiclair left a comment

klajdipaja commented Sep 18, 2024

arosiclair Sep 18, 2024

arosiclair commented Sep 18, 2024

arosiclair left a comment

mollfpr commented Sep 19, 2024 •

edited

Loading

mollfpr left a comment

neil-marcellini left a comment

klajdipaja commented Sep 23, 2024

neil-marcellini commented Sep 24, 2024

melvin-bot bot commented Sep 24, 2024

OSBotify commented Sep 24, 2024

OSBotify commented Sep 24, 2024

github-actions bot commented Sep 27, 2024

ikevin127 commented Nov 4, 2024

	}, [accountID, sortedVisibleReportActions, unreadMarkerTime]);
	}, [sortedVisibleReportActions, unreadMarkerTime]);

[GH-47817]- remove messageManuallyMarkedUnread and manual handling of… #49367

[GH-47817]- remove messageManuallyMarkedUnread and manual handling of… #49367

Conversation

klajdipaja commented Sep 18, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 18, 2024

github-actions bot commented Sep 18, 2024 • edited Loading

klajdipaja commented Sep 18, 2024

arosiclair left a comment

Choose a reason for hiding this comment

klajdipaja commented Sep 18, 2024

arosiclair Sep 18, 2024

Choose a reason for hiding this comment

arosiclair commented Sep 18, 2024

arosiclair left a comment

Choose a reason for hiding this comment

mollfpr commented Sep 19, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

klajdipaja commented Sep 23, 2024

neil-marcellini commented Sep 24, 2024

melvin-bot bot commented Sep 24, 2024

OSBotify commented Sep 24, 2024

OSBotify commented Sep 24, 2024

github-actions bot commented Sep 27, 2024

ikevin127 commented Nov 4, 2024

klajdipaja commented Sep 18, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024 •

edited

Loading

mollfpr commented Sep 19, 2024 •

edited

Loading