Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2FA magic code input behind keyboard #48993

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix 2FA magic code input behind keyboard #48993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/pages/settings/Security/TwoFactorAuth/StepWrapper/StepWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ function StepWrapper({
<ScreenWrapper
shouldShowOfflineIndicator={false}
shouldEnableKeyboardAvoidingView={shouldEnableKeyboardAvoidingView}
shouldEnableMaxHeight
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This to fix on iOS mWeb.

Screenshot 2024-09-11 at 22 15 00

testID={StepWrapper.displayName}
>
<AnimatedStep
Expand Down
1 change: 0 additions & 1 deletion src/pages/settings/Security/TwoFactorAuth/Steps/GetCode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ function GetCode({account}: GetCodeProps) {
return (
<StepWrapper
title={translate('twoFactorAuth.disableTwoFactorAuth')}
shouldEnableKeyboardAvoidingView={false}
onBackButtonPress={() => setStep(CONST.TWO_FACTOR_AUTH_STEPS.ENABLED, CONST.ANIMATION_DIRECTION.OUT)}
onEntryTransitionEnd={() => formRef.current && formRef.current.focus()}
>
Expand Down
Loading