fix: turn off selection mode if all active options are deleted #48547

dominictb · 2024-09-04T12:06:30Z

Details

Fixed Issues

$ #47057
PROPOSAL: #47057 (comment)

Tests

Launch New Expensify app.
Go to workspace settings > Categories.
Long press on the category.
Select all categories and bulk delete them.

Verify that: Selection mode will exit after deleting all the categories.

Go to workspace settings > Report fields.
Long press on the report field.
Select all report fields and bulk delete them.

Verify that: Selection mode will exit after deleting all the report fields.

Verify that no errors appear in the JS console

Offline tests

Launch New Expensify app.
Go to workspace settings > Categories.
Long press on the category.
Select all categories and bulk delete them.

Verify that: Selection mode will exit after deleting all the categories.

Go to workspace settings > Report fields.
Long press on the report field.
Select all report fields and bulk delete them.

Verify that: Selection mode will exit after deleting all the report fields.

QA Steps

Launch New Expensify app.
Go to workspace settings > Categories.
Long press on the category.
Select all categories and bulk delete them.

Verify that: Selection mode will exit after deleting all the categories.

Go to workspace settings > Report fields.
Long press on the report field.
Select all report fields and bulk delete them.

Verify that: Selection mode will exit after deleting all the report fields.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

compressed_android.webm.mp4

Android: mWeb Chrome

compressed_aweb.webm.mp4

iOS: Native

compressed_ios.mp4.mp4

Screen.Recording.2024-09-15.at.00.15.44.mov

iOS: mWeb Safari

compressed_iosweb.mp4.mp4

MacOS: Chrome / Safari

compressed_desktop.mov.mp4

MacOS: Desktop

compressed_desktop.mov.mp4

melvin-bot · 2024-09-04T12:06:35Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ntdiary · 2024-09-05T09:46:28Z

@dominictb, The result in the video is that it didn't exit selection mode.

dominictb · 2024-09-06T07:40:01Z

@ntdiary

I updated the PR to move these auto turn-off selection mode logics:

  const hasActiveOption = some(
        flatMap(sections, (section) => section.data),
        (option) => !option.isDisabled,
    );

    const prevHasActiveOption = usePrevious(hasActiveOption);
    useEffect(() => {
        if (props.shouldAutoTurnOffWhenHasNoActiveOption && !hasActiveOption && prevHasActiveOption) {
            turnOffMobileSelectionMode();
        }
    }, [hasActiveOption, prevHasActiveOption]);

to a new hook, instead of adding it to this here as I did previously. It will fix the bug you mentioned:

The result in the video is that it didn't exit selection mode.

Offline

Screen.Recording.2024-09-06.at.14.44.59.mov

Online

Screen.Recording.2024-09-06.at.14.46.03.mov

ntdiary · 2024-09-09T15:42:11Z

Hi, @Julesssss, How about fixing tags and report fields page at the same time? If needed, maybe we could slightly increase the bounty? BTW, I'm also testing the display of multi-level tags, hoping to provide some insights for further changes. :)

The actual result in the OP mentioned it:

The same happens in Tags and Report fields page.

Julesssss · 2024-09-10T13:10:22Z

How about fixing tags and report fields page at the same time? If needed, maybe we could slightly increase the bounty?

Sounds good to me. I'm unfamiliar with multi-level tagging, perhaps we can create a separate issue for that one once we are done here.

Julesssss · 2024-09-10T13:10:52Z

@ntdiary are you happy for the bounty to be bumped by 50% for the Tags and Report fields page?

ntdiary · 2024-09-10T16:32:41Z

Sounds good to me. I'm unfamiliar with multi-level tagging, perhaps we can create a separate issue for that one once we are done here.

@ntdiary are you happy for the bounty to be bumped by 50% for the Tags and Report fields page?

@Julesssss, I'm really happy for the bounty. But after investigating, I think we can fix the category page and report fields page in this PR. As for tags and multi-level tags, since they are conditionally distinguished in the WorkspaceTagsPage, it would be better to address them in a separate issue to make testing easier. Additionally, multi-level tags also have a WorkspaceViewTagsPage component. 😄

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Lines 90 to 92 in fda4e1b

    
           const tagList = useMemo<TagListItem[]>(() => { 
        
               if (isMultiLevelTags) { 
        
                   return policyTagLists.map((policyTagList) => ({

ntdiary · 2024-09-11T14:13:29Z

Hi, @dominictb, when you have time, can you please also apply the fix to report fields page and add test steps? After that, I'll fill the checklist. :)

…/47057-off-selection

…b/epsf-app into fix/47057-off-selection

dominictb · 2024-09-14T17:16:30Z

@ntdiary Applied fix, added test steps and retested:

Screen.Recording.2024-09-15.at.00.15.44.mov

ntdiary · 2024-09-18T02:48:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

48547-android-native.mp4

Android: mWeb Chrome

48547-android-web.mp4

iOS: Native

48547-ios-native.mp4

iOS: mWeb Safari

48547-ios-web.mp4

MacOS: Chrome / Safari

48547-web.mp4

MacOS: Desktop

48547-desktop.mp4

ntdiary

LGTM.

OSBotify · 2024-09-18T10:02:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-18T22:53:04Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-19T23:33:33Z

🚀 Deployed to production by https://github.com/grgia in version: 9.0.38-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: turn off selection mode if all active options are deleted

d6cd13f

dominictb requested a review from a team as a code owner September 4, 2024 12:06

melvin-bot bot requested review from ntdiary and removed request for a team September 4, 2024 12:06

fix: create new hook

1b93e11

dominictb added 3 commits September 14, 2024 23:59

Merge branch 'main' of https://github.com/dominictb/epsf-app into fix…

f57e784

…/47057-off-selection

Merge branch 'fix/47057-off-selection' of https://github.com/dominict…

e1ba272

…b/epsf-app into fix/47057-off-selection

apply fix for the report fields page

d9f7c8e

ntdiary approved these changes Sep 18, 2024

View reviewed changes

melvin-bot bot requested a review from Julesssss September 18, 2024 06:09

Julesssss approved these changes Sep 18, 2024

View reviewed changes

Julesssss merged commit d13f37b into Expensify:main Sep 18, 2024
17 checks passed

github-actions bot mentioned this pull request Sep 18, 2024

Deploy Checklist: New Expensify 2024-09-18 #49427

Closed

43 tasks

dominictb mentioned this pull request Sep 27, 2024

[$375] Categories - Selection mode remains after deleting all the categories #47057

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: turn off selection mode if all active options are deleted #48547

fix: turn off selection mode if all active options are deleted #48547

dominictb commented Sep 4, 2024 •

edited

Loading

melvin-bot bot commented Sep 4, 2024

ntdiary commented Sep 5, 2024

dominictb commented Sep 6, 2024 •

edited

Loading

ntdiary commented Sep 9, 2024 •

edited

Loading

Julesssss commented Sep 10, 2024

Julesssss commented Sep 10, 2024

ntdiary commented Sep 10, 2024

ntdiary commented Sep 11, 2024

dominictb commented Sep 14, 2024 •

edited

Loading

ntdiary commented Sep 18, 2024 •

edited

Loading

ntdiary left a comment

OSBotify commented Sep 18, 2024

OSBotify commented Sep 18, 2024

OSBotify commented Sep 19, 2024

fix: turn off selection mode if all active options are deleted #48547

fix: turn off selection mode if all active options are deleted #48547

Conversation

dominictb commented Sep 4, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 4, 2024

ntdiary commented Sep 5, 2024

dominictb commented Sep 6, 2024 • edited Loading

Offline

Online

ntdiary commented Sep 9, 2024 • edited Loading

Julesssss commented Sep 10, 2024

Julesssss commented Sep 10, 2024

ntdiary commented Sep 10, 2024

ntdiary commented Sep 11, 2024

dominictb commented Sep 14, 2024 • edited Loading

ntdiary commented Sep 18, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ntdiary left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 18, 2024

OSBotify commented Sep 18, 2024

OSBotify commented Sep 19, 2024

dominictb commented Sep 4, 2024 •

edited

Loading

dominictb commented Sep 6, 2024 •

edited

Loading

ntdiary commented Sep 9, 2024 •

edited

Loading

dominictb commented Sep 14, 2024 •

edited

Loading

ntdiary commented Sep 18, 2024 •

edited

Loading