feat: update the workspace connected bank account page for clarity and consistency #48443

BhuvaneshPatil · 2024-09-03T03:12:59Z

Details

New Design changes

Fixed Issues

$ #47578
PROPOSAL: #47578 (comment)

Tests

Go to any workspace -> workflow -> connect bank account
Verify if new illustration is present, and verify if page matches the design
If user has personal bank account added, then only note should be shown

Verify that no errors appear in the JS console

Offline tests

Connect bank account for workspace page can't be opened if we are offline

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-09-03.at.8.18.42.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-09-03.at.8.26.24.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-03.at.8.17.20.AM.mov

MacOS: Desktop

melvin-bot · 2024-09-03T03:13:04Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

BhuvaneshPatil · 2024-09-03T03:14:40Z

@Ollyws I have asked in slack for confirmation on translation. I will complete the check list once we get feedback on design. For reference I have attached ios native, ios mweb, and we macos chrome screen recordings.

Ollyws · 2024-09-03T10:11:06Z

src/pages/ReimbursementAccount/BankAccountStep.tsx

-                            success
-                            innerStyles={[styles.pr2, styles.pl4, styles.h13]}
-                        />
+                        {!personalBankAccount.plaidAccountID && (


Shouldn't this be the other way around? According to #47578 (comment)

I don't think the note needs to be visible if they haven't ever added a personal bank account

yeah, that makes sense. Will update the PR

Ollyws · 2024-09-04T12:39:56Z

@BhuvaneshPatil is personalBankAccount actually returning data for you? I have a test personal bank account added but it just seems to be returning {}

BhuvaneshPatil · 2024-09-04T13:00:09Z

@Ollyws I tried adding personal account but was unsuccessful at it.
Can you please tell me steps (or slack msg) about adding personal bank account.

Ollyws · 2024-09-04T13:06:15Z

@BhuvaneshPatil, sure.
Go to settings > troubleshooting and set use staging server to true.
Then you can just go through the Plaid flow as normal, choose Chase bank and it will open a modal 'First Platypus Bank'. Use the username user_good and the password pass_good and complete the flow.

BhuvaneshPatil · 2024-09-04T14:00:27Z

I checked ONYXKEYS.PERSONAL_BANK_ACCOUNT is being used to store the account info for account that is being added, not already added one.

Also I found out -
We can use ONYXKEYS.BANK_ACCOUNT_LIST for getting info about user's bank accounts.
It's object where key is account id.

We can use this for getting checking if user has added bank accounts.

BhuvaneshPatil · 2024-09-04T14:08:52Z

Screen.Recording.2024-09-04.at.7.36.39.PM.mov

Ollyws · 2024-09-04T14:51:39Z

Yeah BANK_ACCOUNT_LIST seems like the correct key let's go with that but only target personal accounts.

…date-workspace-page

BhuvaneshPatil · 2024-09-07T16:35:55Z

^ @Ollyws

Ollyws · 2024-09-08T12:06:47Z

src/pages/ReimbursementAccount/BankAccountStep.tsx

+                            </View>
+                        )}
+                        <View style={styles.mt3}>
+                            <MenuItem


Just curious, why are we changing this from Button to MenuItem?

and also why wrap it in a view?

As per design we don't want that button to be highlighted, so to be consistent with other option I have used MenuItem

I have used view as kind of wrapper/container as we have done for other MenuItem and apply margin

Ollyws · 2024-09-09T08:58:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Ollyws

LGTM.

OSBotify · 2024-09-09T17:32:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

BhuvaneshPatil · 2024-09-19T18:27:51Z

@francoisl I can see the changes on staging but we didn't get the notification here.

francoisl · 2024-09-23T21:06:51Z

Ah, yes it was this checklist: #48791 - iirc the automation failed on that day. Anyway, looks like there's a follow-up PR #49490 for this?

BhuvaneshPatil · 2024-09-24T02:35:14Z

Yes

feat: update add bank account step page with latest design

36a0df2

BhuvaneshPatil requested a review from a team as a code owner September 3, 2024 03:13

melvin-bot bot requested a review from Ollyws September 3, 2024 03:13

melvin-bot bot removed the request for review from a team September 3, 2024 03:13

Ollyws reviewed Sep 3, 2024

View reviewed changes

remove not condition

8a9aa7f

BhuvaneshPatil added 3 commits September 5, 2024 22:06

used different onyx value for bank accounts

ab88090

Merge branch 'main' of https://github.com/Expensify/App into 47578-up…

ea9f88f

…date-workspace-page

fix the text going out

71fa816

BhuvaneshPatil requested a review from Ollyws September 5, 2024 19:46

Ollyws reviewed Sep 8, 2024

View reviewed changes

Ollyws approved these changes Sep 9, 2024

View reviewed changes

melvin-bot bot requested a review from francoisl September 9, 2024 09:00

francoisl approved these changes Sep 9, 2024

View reviewed changes

francoisl merged commit b5bca1a into Expensify:main Sep 9, 2024
16 of 19 checks passed

github-actions bot mentioned this pull request Sep 9, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #48820

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update the workspace connected bank account page for clarity and consistency #48443

feat: update the workspace connected bank account page for clarity and consistency #48443

BhuvaneshPatil commented Sep 3, 2024 •

edited

Loading

melvin-bot bot commented Sep 3, 2024

BhuvaneshPatil commented Sep 3, 2024

Ollyws Sep 3, 2024

BhuvaneshPatil Sep 3, 2024

Ollyws commented Sep 4, 2024

BhuvaneshPatil commented Sep 4, 2024

Ollyws commented Sep 4, 2024

BhuvaneshPatil commented Sep 4, 2024

BhuvaneshPatil commented Sep 4, 2024

Ollyws commented Sep 4, 2024

BhuvaneshPatil commented Sep 7, 2024

Ollyws Sep 8, 2024

Ollyws Sep 8, 2024

BhuvaneshPatil Sep 8, 2024

Ollyws commented Sep 9, 2024

Ollyws left a comment

OSBotify commented Sep 9, 2024

BhuvaneshPatil commented Sep 19, 2024

francoisl commented Sep 23, 2024

BhuvaneshPatil commented Sep 24, 2024

feat: update the workspace connected bank account page for clarity and consistency #48443

feat: update the workspace connected bank account page for clarity and consistency #48443

Conversation

BhuvaneshPatil commented Sep 3, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 3, 2024

BhuvaneshPatil commented Sep 3, 2024

Ollyws Sep 3, 2024

Choose a reason for hiding this comment

BhuvaneshPatil Sep 3, 2024

Choose a reason for hiding this comment

Ollyws commented Sep 4, 2024

BhuvaneshPatil commented Sep 4, 2024

Ollyws commented Sep 4, 2024

BhuvaneshPatil commented Sep 4, 2024

BhuvaneshPatil commented Sep 4, 2024

Ollyws commented Sep 4, 2024

BhuvaneshPatil commented Sep 7, 2024

Ollyws Sep 8, 2024

Choose a reason for hiding this comment

Ollyws Sep 8, 2024

Choose a reason for hiding this comment

BhuvaneshPatil Sep 8, 2024

Choose a reason for hiding this comment

Ollyws commented Sep 9, 2024

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 9, 2024

BhuvaneshPatil commented Sep 19, 2024

francoisl commented Sep 23, 2024

BhuvaneshPatil commented Sep 24, 2024

BhuvaneshPatil commented Sep 3, 2024 •

edited

Loading